Skip to content

chore: bump root pnpm to 11.1.2#76

Merged
Boshen merged 2 commits into
mainfrom
chore/pnpm-11.1.2-root-package-manager
May 18, 2026
Merged

chore: bump root pnpm to 11.1.2#76
Boshen merged 2 commits into
mainfrom
chore/pnpm-11.1.2-root-package-manager

Conversation

@Boshen
Copy link
Copy Markdown
Member

@Boshen Boshen commented May 17, 2026

Summary

  • bump the root packageManager pin to pnpm@11.1.2
  • keep the change scoped to the top-level package.json only
  • avoid lockfile, workflow, docs, and nested package changes

Testing

  • not run (root packageManager metadata change only)

@Boshen Boshen force-pushed the chore/pnpm-11.1.2-root-package-manager branch from efec967 to 142e535 Compare May 17, 2026 16:02
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 36b22c0fac

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread pnpm-lock.yaml
@Boshen Boshen force-pushed the chore/pnpm-11.1.2-root-package-manager branch from 36b22c0 to f75a33f Compare May 18, 2026 03:11
@sapphi-red
Copy link
Copy Markdown
Member

I haven't looked into the reason but upgrading to pnpm v11 makes the pnpm install fail: https://github.com/rolldown/plugins/actions/runs/26011183367/job/76451952521?pr=67#step:5:37

Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: f75a33f8af

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread pnpm-workspace.yaml
Boshen added 2 commits May 18, 2026 13:33
…nd approve native builds

The `file:../../babel` references in the 4 benchmark packages trigger a
pnpm 11 crash during the lifecycle re-import step (pnpm/pnpm#11663 /
pnpm/pnpm#11662, still in draft). Aligning with the other plugins'
`workspace:*` pattern sidesteps the bug; benchmarks must now run after
`pnpm build`, same as every other workspace plugin.

Also fills in the `allowBuilds` template pnpm 11 prompts for, allowing
`@swc/core` (native bindings for benchmarks) and `playwright-chromium`
(Chromium download for examples e2e).
@Boshen Boshen force-pushed the chore/pnpm-11.1.2-root-package-manager branch from f75a33f to 2a49a2a Compare May 18, 2026 05:35
@Boshen Boshen merged commit e3cf1ad into main May 18, 2026
14 checks passed
@Boshen Boshen deleted the chore/pnpm-11.1.2-root-package-manager branch May 18, 2026 05:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants